Issue 458483003: Revert 288319 "Adding the VerifyModule function (and helpers) to..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 458483003: Revert 288319 "Adding the VerifyModule function (and helpers) to..." (Closed)

Created:
6 years, 4 months ago by mef

Modified:
6 years, 4 months ago

Reviewers:
krstnmnlsn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 288319 "Adding the VerifyModule function (and helpers) to..." > Adding the VerifyModule function (and helpers) to safe browsing. > > This function allows us to compare a module in memory with > its original on disk, and identify any differences (after > accounting for relocations). The state of the module > (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is > returned along with a list of the possibly modified exported > functions of the module. > > > BUG=401854 > > Review URL: https://codereview.chromium.org/406043003 TBR=krstnmnlsn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288356

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -528 lines)			Patch
D	trunk/src/chrome/browser/safe_browsing/module_integrity_verifier_win.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	trunk/src/chrome/browser/safe_browsing/module_integrity_verifier_win.cc	View	1 chunk	+0 lines, -298 lines	0 comments	Download
D	trunk/src/chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc	View	1 chunk	+0 lines, -157 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/tools/metrics/histograms/histograms.xml	View	2 chunks	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r288356 (tree was closed).

Expand Messages | Collapse Messages