Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1656)

Unified Diff: Tools/GardeningServer/ui/ct-test-list.html

Issue 458473003: Group similar failures (same directory, same fixture) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: updates Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/ui/ct-test-list-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-test-list.html
diff --git a/Tools/GardeningServer/ui/ct-test-list.html b/Tools/GardeningServer/ui/ct-test-list.html
index 5568099edc75bc56b7d2afc46c3b6c77203b438a..bcd87620290172b568cae4c24db7690ff3a783f5 100644
--- a/Tools/GardeningServer/ui/ct-test-list.html
+++ b/Tools/GardeningServer/ui/ct-test-list.html
@@ -4,24 +4,87 @@ Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
+<link rel="import" href="../bower_components/paper-icon-button/paper-icon-button.html">
+
<polymer-element name="ct-test-list" attributes="tests tree">
<template>
<style>
:host {
display: block;
}
+
+ paper-icon-button {
+ vertical-align: middle;
+ }
</style>
- <template repeat="{{ test in tests }}">
+ <template repeat="{{ groups in testGroups_ }}">
<!-- FIXME: Find a less redundant UI than repeating the step on each line. -->
- <div>
- {{ test.step }}
- <template if="{{ test.testName }}"><a href="{{ test | flakinessDashboardURL }}">{{ test.testName }}</a></template>
- <template if="{{ !test.testName }}"><b>whole step failed</b></template>
- </div>
+ <template repeat="{{ group in groups.tests }}">
+ <!-- Case 1: entire step failed -->
+ <template if="{{ !group.name }}">
+ <div>{{ groups.step }} <b>whole step failed</b></div>
+ </template>
+ <!-- Case 2: single test failure -->
+ <template if="{{ group.name && (group.tests.length == 1 || group.expanded) }}">
+ <template repeat="{{ test in group.tests }}">
+ <div>
+ {{ groups.step }}
+ <a href="{{ test | flakinessDashboardURL }}">{{ test.testName }}</a>
+ </div>
+ </template>
+ </template>
+ <!-- Case 3: group of tests failed -->
+ <template if="{{ group.name && group.tests.length > 1 && !group.expanded }}">
+ <div>
+ {{ groups.step }} {{ group.name }} ({{ group.tests.length }} Tests)
+ <paper-icon-button id="expand" icon="more-vert" step="{{ groups.step }}" group="{{ group.name }}" on-click="{{ _expand }}"></paper-icon-button>
+ </div>
+ </template>
+ </template>
</template>
</template>
<script>
- Polymer({
+ Polymer('ct-test-list', {
+ testsChanged: function() {
+ var groups = {};
+ if (this.tests) {
+ this.tests.forEach(function(test) {
+ if (!groups[test.step])
+ groups[test.step] = {};
+ var testName = test.reasonGroupName();
+ if (!groups[test.step][testName])
+ groups[test.step][testName] = [];
+ groups[test.step][testName].push(test);
+ }.bind(this));
+ }
+ this.testGroups_ = [];
+ Object.keys(groups, function(step, testsByName) {
+ var tests = [];
+ Object.keys(testsByName, function(name, testList) {
+ if (name == 'undefined')
+ name = undefined;
+ tests.push({'name': name, 'tests': testList, 'expanded': false});
+ }.bind(this));
+ tests.sortBy('name');
+ this.testGroups_.push({'step': step, 'tests': tests});
+ }.bind(this));
+ this.testGroups_.sortBy('step');
+ },
+
+ _expand: function(evt) {
+ step = evt.target.attributes['step'].value;
+ name = evt.target.attributes['group'].value;
+ this.testGroups_.forEach(function(testGroup) {
+ if (testGroup.step == step) {
+ testGroup.tests.forEach(function(test) {
+ // FIXME: This attribute should be persisted over reloads.
+ if (test.name == name)
+ test.expanded = true;
+ });
+ }
+ });
+ },
+
flakinessDashboardURL: function(test) {
return test.flakinessDashboardURL(this.tree);
},
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/ui/ct-test-list-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698