Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 458443002: IDL compiler: Add a helper method for has_custom_getter and has_custom_setter (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

IDL compiler: Add a helper method for has_custom_getter and has_custom_setter This refactoring is needed to make this CL (https://codereview.chromium.org/447523003/) as smaller as possible. (I'm planning to land & revert the CL a couple of times, so I want to make the CL as smaller as possible.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 4 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-08-08 09:53:35 UTC) #1
Jens Widell
LGTM
6 years, 4 months ago (2014-08-08 09:57:00 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-08 09:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/458443002/1
6 years, 4 months ago (2014-08-08 09:58:13 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 11:34:56 UTC) #5
Message was sent while issue was closed.
Change committed as 179822

Powered by Google App Engine
This is Rietveld 408576698