Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 458423002: Fix gn android component build (Closed)

Created:
6 years, 4 months ago by cjhopman
Modified:
6 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
cjhopman
Not sure if I actually uploaded this correctly (just did it from my chromium checkout ...
6 years, 4 months ago (2014-08-11 23:03:38 UTC) #1
Michael Achenbach
Jochen, can you please take a look?
6 years, 4 months ago (2014-08-12 06:32:00 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-12 07:44:34 UTC) #3
Michael Achenbach
Is this a requirement for the current roll?
6 years, 4 months ago (2014-08-12 11:19:27 UTC) #4
jochen (gone - plz use gerrit)
On 2014/08/12 at 11:19:27, machenbach wrote: > Is this a requirement for the current roll? ...
6 years, 4 months ago (2014-08-12 12:03:10 UTC) #5
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 4 months ago (2014-08-15 23:35:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/cjhopman@chromium.org/458423002/1
6 years, 4 months ago (2014-08-15 23:36:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 23:36:06 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-15 23:36:07 UTC) #9
Michael Achenbach
FYI: No CQ support for V8. Use 'git cl dcommit'.
6 years, 4 months ago (2014-08-21 08:09:23 UTC) #10
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-02 10:21:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698