Oilpan: RenderImageResource::shutdown should be called earlier.

Oilpan: RenderImageResource::shutdown should be called earlier.

This CL fixes flaky crashes in tables/mozilla/bugs/.

RenderImageResource::shutdown unregisters the owner RenderImage from an
ImageResource. We should call it in RenderImage::destroy because
RenderObject::willRenderImage, which is a callback of ImageResourceClient,
should not be called after RenderImage::destroy.

BUG=398342
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180029

[tkent, 2014-08-12 03:27:04]

Please review this.
This will fix the following flaky failures.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLarge...

[haraken, 2014-08-12 03:34:14]

LGTM.

I think we should dispatch the destroy chain for the entire RenderObject
hierarchy before destructing the RenderObject. Does this CL fix all of them?

[tkent, 2014-08-12 03:51:24]

On 2014/08/12 03:34:14, haraken wrote:
> I think we should dispatch the destroy chain for the entire RenderObject
> hierarchy before destructing the RenderObject. Does this CL fix all of them?

destroy() is correctly called for each of RenderObject.  You misunderstand
something.
Anyway, I found other instances which we should move destructor content to
destroy().  A CL follows.

[tkent, 2014-08-12 03:51:47]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-08-12 03:52:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/458383003/1

[haraken, 2014-08-12 03:56:08]

On 2014/08/12 03:51:24, tkent wrote:
> On 2014/08/12 03:34:14, haraken wrote:
> > I think we should dispatch the destroy chain for the entire RenderObject
> > hierarchy before destructing the RenderObject. Does this CL fix all of them?
> 
> destroy() is correctly called for each of RenderObject.  You misunderstand
> something.
> Anyway, I found other instances which we should move destructor content to
> destroy().  A CL follows.

Ah, I was misreading the diff.

[commit-bot: I haz the power, 2014-08-12 04:31:33]

Change committed as 180029