Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 458373003: Full invalidate <img> on resize (Closed)

Created:
6 years, 4 months ago by Xianzhu
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Full invalidate <img> on resize Because <img> scale its contents on resize, incremental invalidation doesn't apply to it. Force full invalidate if the image content is resized during layout. BUG=397939 TEST=fast/repaint/image-resize.html TEST=fast/repaint/percent-size-image-resize-container.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180015

Patch Set 1 #

Total comments: 3

Patch Set 2 : For landing #

Patch Set 3 : Rebaseline fast/repaint/list-marker-2.html #

Messages

Total messages: 10 (0 generated)
Xianzhu
6 years, 4 months ago (2014-08-11 21:11:05 UTC) #1
leviw_travelin_and_unemployed
Okay. LGTM. https://codereview.chromium.org/458373003/diff/1/LayoutTests/fast/repaint/percent-size-image-resize-container-expected.txt File LayoutTests/fast/repaint/percent-size-image-resize-container-expected.txt (left): https://codereview.chromium.org/458373003/diff/1/LayoutTests/fast/repaint/percent-size-image-resize-container-expected.txt#oldcode9 LayoutTests/fast/repaint/percent-size-image-resize-container-expected.txt:9: [1, 0, 314, 307] I hate git's ...
6 years, 4 months ago (2014-08-11 22:09:26 UTC) #2
Xianzhu
https://codereview.chromium.org/458373003/diff/1/Source/core/rendering/RenderImage.cpp File Source/core/rendering/RenderImage.cpp (right): https://codereview.chromium.org/458373003/diff/1/Source/core/rendering/RenderImage.cpp#newcode632 Source/core/rendering/RenderImage.cpp:632: On 2014/08/11 22:09:26, leviw wrote: > Nit: remove Done.
6 years, 4 months ago (2014-08-11 22:25:16 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-11 22:25:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/458373003/20001
6 years, 4 months ago (2014-08-11 22:26:08 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-11 23:27:31 UTC) #6
Xianzhu
The CQ bit was unchecked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-11 23:37:19 UTC) #7
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-11 23:40:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/458373003/40001
6 years, 4 months ago (2014-08-11 23:41:41 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 00:46:26 UTC) #10
Message was sent while issue was closed.
Change committed as 180015

Powered by Google App Engine
This is Rietveld 408576698