Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 458353005: DevTools: always zoom on wheel in flame chart. (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
Reviewers:
alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: always zoom on wheel in flame chart. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180091

Patch Set 1 #

Total comments: 2

Patch Set 2 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/devtools/front_end/components/FlameChart.js View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pfeldman
6 years, 4 months ago (2014-08-12 12:59:04 UTC) #1
alph
lgtm https://codereview.chromium.org/458353005/diff/1/Source/devtools/front_end/components/FlameChart.js File Source/devtools/front_end/components/FlameChart.js (right): https://codereview.chromium.org/458353005/diff/1/Source/devtools/front_end/components/FlameChart.js#newcode567 Source/devtools/front_end/components/FlameChart.js:567: var panVertically = e.shiftKey && (e.wheelDeltaY || Math.abs(e.wheelDeltaX) ...
6 years, 4 months ago (2014-08-12 14:50:00 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-12 16:11:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/458353005/1
6 years, 4 months ago (2014-08-12 16:13:13 UTC) #4
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-12 16:17:21 UTC) #5
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-12 16:19:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/458353005/20001
6 years, 4 months ago (2014-08-12 16:20:51 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-12 18:05:14 UTC) #8
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-12 18:15:38 UTC) #9
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-12 18:15:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/458353005/20001
6 years, 4 months ago (2014-08-12 18:16:16 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 18:17:34 UTC) #12
Message was sent while issue was closed. 
Change committed as 180091

Powered by Google App Engine
This is Rietveld 408576698