Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 458353003: Roll buildtools, this updates VS2013 Pro to Update 3 (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
iannucci, brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Roll buildtools, this updates VS2013 Pro to Update 3 TBR=iannucci@chromium.org NOTRY=true BUG=402543 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289650

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : add landmine #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/get_landmines.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
scottmg
this double roll to pull in a sha1 seems a wee bit silly, perhaps i ...
6 years, 4 months ago (2014-08-12 03:41:09 UTC) #1
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-12 03:41:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/458353003/1
6 years, 4 months ago (2014-08-12 03:41:54 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-12 03:47:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/458353003/20001
6 years, 4 months ago (2014-08-12 03:48:24 UTC) #5
scottmg
The CQ bit was unchecked by scottmg@chromium.org
6 years, 4 months ago (2014-08-12 04:02:23 UTC) #6
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-12 04:03:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/458353003/40001
6 years, 4 months ago (2014-08-12 04:03:47 UTC) #8
scottmg
The CQ bit was unchecked by scottmg@chromium.org
6 years, 4 months ago (2014-08-12 04:06:06 UTC) #9
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-13 18:14:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/458353003/60001
6 years, 4 months ago (2014-08-13 18:16:02 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 05:31:27 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 11:33:42 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/5539)
6 years, 4 months ago (2014-08-14 11:33:43 UTC) #14
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-14 16:28:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/458353003/60001
6 years, 4 months ago (2014-08-14 16:30:23 UTC) #16
scottmg
The CQ bit was unchecked by scottmg@chromium.org
6 years, 4 months ago (2014-08-14 18:47:17 UTC) #17
scottmg
Adding notry because it's been 26h and the cq hasn't managed to get through android_aosp.
6 years, 4 months ago (2014-08-14 18:47:47 UTC) #18
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-14 18:47:50 UTC) #19
scottmg
6 years, 4 months ago (2014-08-14 18:48:28 UTC) #20
Message was sent while issue was closed. 
Committed patchset #4 manually as 289650 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698