Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 458333003: Work around NVIDIA driver issue with glLineWidth(NaN) (Closed)

Created:
6 years, 4 months ago by oetuaho-nv
Modified:
6 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Work around NVIDIA driver issue with glLineWidth(NaN) Set line width to 1.0 in the driver in case line width NaN is requested. BUG=402847 TEST=WebGL conformance tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -20 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +21 lines, -1 line 0 comments Download
M gpu/command_buffer/service/context_state.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 4 chunks +42 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oetuaho-nv
Please review.
6 years, 4 months ago (2014-08-12 13:39:59 UTC) #1
Zhenyao Mo
On 2014/08/12 13:39:59, oetuaho-nv wrote: > Please review. For workarounds, we always use https://code.google.com/p/chromium/codesearch#chromium/src/gpu/config/gpu_driver_bug_workaround_type.h&q=gpu_driver&sq=package:chromium&l=1 and ...
6 years, 4 months ago (2014-08-12 22:00:47 UTC) #2
oetuaho-nv
This turned out to not actually be a driver bug. GL spec allows undefined results ...
6 years, 4 months ago (2014-08-13 10:05:09 UTC) #3
Zhenyao Mo
On 2014/08/13 10:05:09, oetuaho-nv wrote: > This turned out to not actually be a driver ...
6 years, 4 months ago (2014-08-13 19:33:22 UTC) #4
Zhenyao Mo
Ken, what do you think about the spec change suggestion?
6 years, 4 months ago (2014-08-13 19:33:42 UTC) #5
Zhenyao Mo
6 years, 4 months ago (2014-08-13 19:38:50 UTC) #6
Message was sent while issue was closed.
Never mind here, I see your other CL doing this already.

Powered by Google App Engine
This is Rietveld 408576698