Issue 45823003: [net/http] Add HttpStreamParser.Websocket101Response test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45823003: [net/http] Add HttpStreamParser.Websocket101Response test (Closed)

Created:
7 years, 1 month ago by szym

Modified:
7 years, 1 month ago

Reviewers:
Adam Rice

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[net/http] Add HttpStreamParser.Websocket101Response test Verify that after parsing 1xx response with ReadResponseHeaders, HttpResponseInfo contains the parsed headers and the response buffer contains the response that follows. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233428

Patch Set 1 : . #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -0 lines)			Patch
	M	net/http/http_stream_parser_unittest.cc	View		2 chunks	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

szym

On 2013/11/06 00:24:04, Adam Rice wrote: > lgtm Interestingly, this test fails before http://crrev.com/226539

7 years, 1 month ago (2013-11-06 06:22:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/45823003/30001

7 years, 1 month ago (2013-11-06 18:19:51 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-11-06 18:40:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/45823003/30001

7 years, 1 month ago (2013-11-06 18:50:54 UTC) #5

Message was sent while issue was closed.

Change committed as 233428

Expand Messages | Collapse Messages