Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: Source/core/dom/FullscreenElementStack.cpp

Issue 458223003: Remove the fullscreen element stack exemption for webkitRequestFullScreen() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: spec typo Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fullscreen/full-screen-twice-expected.txt ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/FullscreenElementStack.cpp
diff --git a/Source/core/dom/FullscreenElementStack.cpp b/Source/core/dom/FullscreenElementStack.cpp
index db98e5b8d0fdb8bd9bd2c0ee2046d18ae596df35..075c6f486ed48db1c41c59a0752adaf3678371c1 100644
--- a/Source/core/dom/FullscreenElementStack.cpp
+++ b/Source/core/dom/FullscreenElementStack.cpp
@@ -186,15 +186,11 @@ bool FullscreenElementStack::elementReady(Element& element, RequestType requestT
return false;
}
- // element's node document fullscreen element stack is either empty or its top element is an
+ // element's node document's fullscreen element stack is either empty or its top element is an
// ancestor of element.
- if (Element* lastElementOnStack = fullscreenElementFrom(element.document())) {
- if (!element.isDescendantOf(lastElementOnStack)) {
- if (requestType == PrefixedMozillaRequest || requestType == PrefixedMozillaAllowKeyboardInputRequest)
- UseCounter::count(element.document(), UseCounter::LegacyFullScreenErrorExemption);
- else
- return false;
- }
+ if (Element* topElement = fullscreenElementFrom(element.document())) {
+ if (!element.isDescendantOf(topElement))
+ return false;
}
// element has no ancestor element whose local name is iframe and namespace is the HTML
« no previous file with comments | « LayoutTests/fullscreen/full-screen-twice-expected.txt ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698