Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 458213002: DevTools: add test to verify simple selector behavior. (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: add test to verify simple selector behavior. DOMPresentationUtils.simpleSelector behavior used to be fixated in a couple of tests that dumped default selector in a new style rule section. This patch adds a separate test for simpleSelector method and removes the calls to default selector in the affected tests. This makes it possible to use InspectorTets.addNewRule in these tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179952

Patch Set 1 #

Patch Set 2 : migrate to addNewRule method #

Patch Set 3 : WebInspector.BlankStylePropertiesSection.makeNormal is private #

Messages

Total messages: 5 (0 generated)
lushnikov
Please, take a look. This patch is needed for the https://codereview.chromium.org/441873010/ which affects InspectorTest.addNewRule method.
6 years, 4 months ago (2014-08-11 13:21:22 UTC) #1
apavlov
lgtm
6 years, 4 months ago (2014-08-11 13:25:41 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-11 13:26:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/458213002/40001
6 years, 4 months ago (2014-08-11 13:26:33 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:28:18 UTC) #5
Message was sent while issue was closed.
Change committed as 179952

Powered by Google App Engine
This is Rietveld 408576698