Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 458183002: Restores AudioAndroidOutputTest.StartOutputStreamCallbacksNonDefaultParameters (Closed)

Created:
6 years, 4 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Restores AudioAndroidOutputTest.StartOutputStreamCallbacksNonDefaultParameters. BUG=374038 TEST=local tests on Nexus 7. Nexus 5 and Galaxy Note 3 R=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288936

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/audio/android/audio_android_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
henrika (OOO until Aug 14)
I am enabling a unit test which has been disabled on Android for a while. ...
6 years, 4 months ago (2014-08-11 11:12:50 UTC) #1
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/458183002/diff/1/media/audio/android/audio_android_unittest.cc File media/audio/android/audio_android_unittest.cc (right): https://codereview.chromium.org/458183002/diff/1/media/audio/android/audio_android_unittest.cc#newcode829 media/audio/android/audio_android_unittest.cc:829: StartOutputStreamCallbacksNonDefaultParameters) { nit: fits in one line (I ...
6 years, 4 months ago (2014-08-12 08:20:55 UTC) #2
henrika (OOO until Aug 14)
https://codereview.chromium.org/458183002/diff/1/media/audio/android/audio_android_unittest.cc File media/audio/android/audio_android_unittest.cc (right): https://codereview.chromium.org/458183002/diff/1/media/audio/android/audio_android_unittest.cc#newcode829 media/audio/android/audio_android_unittest.cc:829: StartOutputStreamCallbacksNonDefaultParameters) { It did ;-)
6 years, 4 months ago (2014-08-12 08:37:44 UTC) #3
henrika (OOO until Aug 14)
The CQ bit was checked by henrika@chromium.org
6 years, 4 months ago (2014-08-12 08:37:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/458183002/20001
6 years, 4 months ago (2014-08-12 08:38:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 10:02:43 UTC) #6
henrika (OOO until Aug 14)
The CQ bit was unchecked by henrika@chromium.org
6 years, 4 months ago (2014-08-12 10:25:55 UTC) #7
henrika (OOO until Aug 14)
6 years, 4 months ago (2014-08-12 11:59:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as 288936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698