Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 458103002: Avoid handling change event when focusing tree item is sufficient. (Closed)

Created:
6 years, 4 months ago by fukino
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Avoid handling change event when focusing tree item is sufficient. BUG=402319 TEST=manually and run browser_tests gtest_filter=*FileManager* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_tree.js View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fukino
@yoshiki - could you take a look? Thanks!
6 years, 4 months ago (2014-08-11 06:28:23 UTC) #1
yoshiki
lgtm
6 years, 4 months ago (2014-08-12 05:05:42 UTC) #2
fukino
On 2014/08/12 05:05:42, yoshiki wrote: > lgtm Thanks!
6 years, 4 months ago (2014-08-12 05:11:52 UTC) #3
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 4 months ago (2014-08-12 05:11:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/458103002/1
6 years, 4 months ago (2014-08-12 05:14:13 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:38:14 UTC) #6
Message was sent while issue was closed.
Change committed as 288985

Powered by Google App Engine
This is Rietveld 408576698