Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 458053002: Refactor webkit resources targets. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin (slow to review), jam, jochen (gone - plz use gerrit), extensions-reviews_chromium.org, eseidel, Nico, Ben
Project:
chromium
Visibility:
Public.

Description

Refactor webkit resources targets. * First, this was to remove blink_common_resources target that was moved * into third_party/WebKit/public:resources. * Second, the above clean up reduced webkit/BUILD.gn into a single * target that could be moved closer to webkit_resources.grd, becoming * webkit/glue/resources/BUILD.gn and //webkit/glue/resources target, * which is much more inline with the GN philosophy. BUG=400860 TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn R=brettw@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -46 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 3 chunks +5 lines, -3 lines 0 comments Download
D webkit/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
A + webkit/glue/resources/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/webkit_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 4 months ago (2014-08-11 02:40:50 UTC) #1
tfarina
Brett, ping?
6 years, 4 months ago (2014-08-12 02:55:10 UTC) #2
brettw
lgtm
6 years, 4 months ago (2014-08-12 21:35:52 UTC) #3
tfarina
TBRing Ben for this...(since it is just GN changes, which Brett's review cover it).
6 years, 4 months ago (2014-08-12 22:18:59 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-12 22:19:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/458053002/1
6 years, 4 months ago (2014-08-12 22:30:09 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 02:54:51 UTC) #7
Message was sent while issue was closed.
Change committed as 289163

Powered by Google App Engine
This is Rietveld 408576698