Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 45803002: Move more data to .data.rel.ro section (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium, digit1
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move more data to .data.rel.ro section Move CoreException struct and webkitPrefix/bothPrefixes/unprefixed arrays to from .data section to .data.rel.ro by marking them as const. This data can now possibly be shared by separate instances of the library on Android, thus saving RAM. BUG=249746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/dom/DOMException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
7 years, 1 month ago (2013-10-25 22:06:01 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-26 12:45:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/45803002/1
7 years, 1 month ago (2013-10-26 12:45:57 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=14081
7 years, 1 month ago (2013-10-26 14:04:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/45803002/1
7 years, 1 month ago (2013-10-26 14:10:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=14093
7 years, 1 month ago (2013-10-26 15:27:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/45803002/1
7 years, 1 month ago (2013-10-27 15:34:46 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-27 16:15:24 UTC) #8
Message was sent while issue was closed.
Change committed as 160680

Powered by Google App Engine
This is Rietveld 408576698