Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 458013002: content: Add blink_test_environment.* (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
CC:
abarth-chromium, chromium-reviews, darin (slow to review), jam
Project:
chromium
Visibility:
Public.

Description

content: Add blink_test_environment.* It will be used to replace webkit_support.* After this change lands in Chromium, Blink will be updated to include from blink_test_environment.h and call the "new" functions. BUG=None TEST=webkit_unit_tests R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -134 lines) Patch
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A content/test/blink_test_environment.h View 1 chunk +24 lines, -0 lines 0 comments Download
A + content/test/blink_test_environment.cc View 4 chunks +11 lines, -3 lines 0 comments Download
M content/test/webkit_support.h View 1 chunk +3 lines, -8 lines 0 comments Download
D content/test/webkit_support.cc View 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 4 months ago (2014-08-10 04:56:03 UTC) #1
tfarina
Blink side -> https://codereview.chromium.org/461443002/
6 years, 4 months ago (2014-08-10 13:57:38 UTC) #2
abarth-chromium
LGTM, but I'm not an owner.
6 years, 4 months ago (2014-08-10 15:30:24 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
6 years, 4 months ago (2014-08-10 16:28:16 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-11 01:58:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/458013002/1
6 years, 4 months ago (2014-08-11 01:59:30 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 02:38:47 UTC) #7
Message was sent while issue was closed.
Change committed as 288636

Powered by Google App Engine
This is Rietveld 408576698