Make the default RendererPreferences smarter....

Make the default RendererPreferences smarter.

Change the default RenderViewHostDelegate::GetRendererPrefs to a singleton because initialization may not always be cheap (we assume copying is, however).

BUG=29043
TEST=if you focus a link in an extension popup, you can actually see the focus ring (the focus ring had been set to 0x000000 color)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33775

[Evan Stade, 2009-12-03 01:52:28]

I thought about this for a while and didn't find a great way to do this.

This will need syncing with Markus's patch and has implications for Elliot's
later patch. There are two things I'm trying to accomplish here:

1) have a useful default implementation for
RenderViewHostDelegate::GetRendererPreferences() (this will help reduce code
duplication and prevent future errors of the sort that this patch fixes)
2) don't call the initialization function millions of times

we may want to pass the Profile* into GetRendererPreferences so we can determine
whether to follow the system theme. The implementation for
GetRendererPreferences is a little heavy for a class that is otherwise mostly
stubs, but I don't know how to fix that while maintaining (1) and (2)

[Evan Stade, 2009-12-03 01:57:35]

actually I think I have another way I like better.. hold off on reviewing

[Evan Stade, 2009-12-03 02:13:21]

ok, have at it

[Elliot Glaysher, 2009-12-03 18:06:34]

I don't like the assumptions behind this change.

So I start writing the synchronization patch. How do I force a rebuild of the
RenderPreferences struct if, by design, it's a function that owns a static
singleton interface? 

What object will listen for for the theme and subpixel change notifications?
Previously, it was clear that TabContentsViewGtk would be responsible for this.

[Evan Stade, 2009-12-03 18:10:44]

On 2009/12/03 18:06:34, Elliot Glaysher wrote:
> I don't like the assumptions behind this change.
> 
> So I start writing the synchronization patch. How do I force a rebuild of the
> RenderPreferences struct if, by design, it's a function that owns a static
> singleton interface?

add a parameter to GetInitedRendererPreferences that optionally forces
re-initialization

> 
> What object will listen for for the theme and subpixel change notifications?
> Previously, it was clear that TabContentsViewGtk would be responsible for
this.

use GetInitedRendererPreferences with said parameter in GtkThemeProvider

[Elliot Glaysher, 2009-12-03 18:34:10]

I'm not happy about it, but I thought of a way to do this with just a singleton
on the side and a registry of the current live RVHs.  (Singelton object listens
for notification, updated RendererPreferences and then tells each RVH to
update.)

Anyway, LGTM I guess?