Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 457973003: We should call FrameView::updateLayoutAndStyleForPainting before painting (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr., rwlbuis, Stephen Chennney, skobes
Project:
blink
Visibility:
Public.

Description

We should call FrameView::updateLayoutAndStyleForPainting before painting In some obscure code paths (e.g., printing, drawing drag images), we would paint without calling updateLayoutAndStyleForPainting, which means we skip some important steps in the DocumentLifecycle. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180119

Patch Set 1 #

Patch Set 2 : Needs rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-12 20:51:24 UTC) #1
esprehn
lgtm
6 years, 4 months ago (2014-08-12 20:52:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/457973003/1
6 years, 4 months ago (2014-08-12 20:53:20 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-12 21:49:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/457973003/20001
6 years, 4 months ago (2014-08-12 21:50:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-12 22:49:21 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 23:18:26 UTC) #7
Message was sent while issue was closed.
Change committed as 180119

Powered by Google App Engine
This is Rietveld 408576698