Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: nss/lib/freebl/rsa.c

Issue 457963002: Update to NSS 3.16.4. (Closed) Base URL: http://src.chromium.org/svn/trunk/deps/third_party/nss
Patch Set: Include certdata.c changes. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « nss/lib/ckfw/builtins/nssckbi.h ('k') | nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_crldp.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: nss/lib/freebl/rsa.c
diff --git a/nss/lib/freebl/rsa.c b/nss/lib/freebl/rsa.c
index 34bc395fe2baae872645712fb190656100af5738..bdec162b52c4fcb9ca8ad9922772f87083747075 100644
--- a/nss/lib/freebl/rsa.c
+++ b/nss/lib/freebl/rsa.c
@@ -1386,7 +1386,7 @@ RSA_PrivateKeyCheck(const RSAPrivateKey *key)
!key->publicExponent.data || !key->privateExponent.data ||
!key->exponent1.data || !key->exponent2.data ||
!key->coefficient.data) {
- /*call RSA_PopulatePrivateKey first, if the application wishes to
+ /* call RSA_PopulatePrivateKey first, if the application wishes to
* recover these parameters */
err = MP_BADARG;
goto cleanup;
@@ -1415,9 +1415,6 @@ RSA_PrivateKeyCheck(const RSAPrivateKey *key)
rv = SECFailure; \
goto cleanup; \
}
- /*
- * The following errors cannot be recovered from.
- */
/* n == p * q */
CHECK_MPI_OK( mp_mul(&p, &q, &res) );
VERIFY_MPI_EQUAL(&res, &n);
@@ -1435,10 +1432,6 @@ RSA_PrivateKeyCheck(const RSAPrivateKey *key)
/* d*e == 1 mod q-1 */
CHECK_MPI_OK( mp_mulmod(&d, &e, &qsub1, &res) );
VERIFY_MPI_EQUAL_1(&res);
- /*
- * The following errors can be recovered from. However, the purpose of this
- * function is to check consistency, so they are not.
- */
/* d_p == d mod p-1 */
CHECK_MPI_OK( mp_mod(&d, &psub1, &res) );
VERIFY_MPI_EQUAL(&res, &d_p);
« no previous file with comments | « nss/lib/ckfw/builtins/nssckbi.h ('k') | nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_crldp.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698