Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 457933002: Replace Chrome IPC with Mojo IPC for querying BatteryStatus service

Created:
6 years, 4 months ago by darin (slow to review)
Modified:
5 years, 4 months ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, mlamouri (slow - plz ping)
Project:
chromium
Visibility:
Public.

Description

Replace Chrome IPC with Mojo IPC for querying BatteryStatus service

Patch Set 1 #

Patch Set 2 : more hacking #

Patch Set 3 : rebase #

Patch Set 4 : fix build #

Patch Set 5 : move to device/battery #

Patch Set 6 : tweak: make DidChange argument non-nullable #

Patch Set 7 : with functional unit test #

Patch Set 8 : update #

Patch Set 9 : linux support #

Patch Set 10 : update #

Patch Set 11 : move browsertest back to content/browser #

Patch Set 12 : fix compilation errors #

Patch Set 13 : snapshot #

Patch Set 14 : passes browser tests #

Patch Set 15 : fix windows #

Patch Set 16 : fix windows #

Patch Set 17 : fix windows again #

Patch Set 18 : fix mac #

Patch Set 19 : GN build support #

Patch Set 20 : fix GN build #

Patch Set 21 : android support #

Patch Set 22 : android support #

Patch Set 23 : android support #

Patch Set 24 : android fixes, thanks to qsr #

Patch Set 25 : rebase #

Patch Set 26 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+791 lines, -2831 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -0 lines 0 comments Download
M content/app/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +1 line, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +0 lines, -2 lines 0 comments Download
D content/browser/battery_status/OWNERS View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/battery_status/battery_status_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 9 chunks +32 lines, -30 lines 0 comments Download
D content/browser/battery_status/battery_status_manager.h View 1 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_android.h View 1 2 3 4 1 chunk +0 lines, -45 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_android.cc View 1 2 3 4 1 chunk +0 lines, -65 lines 0 comments Download
M content/browser/battery_status/battery_status_manager_chromeos.cc View 1 2 3 4 1 chunk +0 lines, -184 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_default.cc View 1 2 3 4 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_linux.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -34 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_linux.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -383 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_linux_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -143 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_mac.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +0 lines, -288 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_win.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -26 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_win.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -206 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_win_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -80 lines 0 comments Download
D content/browser/battery_status/battery_status_message_filter.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/battery_status/battery_status_message_filter.cc View 1 1 chunk +0 lines, -56 lines 0 comments Download
M content/browser/battery_status/battery_status_service.h View 1 2 3 4 1 chunk +0 lines, -66 lines 0 comments Download
M content/browser/battery_status/battery_status_service.cc View 1 2 3 4 1 chunk +0 lines, -106 lines 0 comments Download
D content/browser/battery_status/battery_status_service_unittest.cc View 1 2 3 4 1 chunk +0 lines, -191 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 4 chunks +7 lines, -3 lines 0 comments Download
D content/common/battery_status_messages.h View 1 2 3 4 1 chunk +0 lines, -32 lines 0 comments Download
M content/common/content_message_generator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +0 lines, -1 line 0 comments Download
M content/content.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 7 chunks +2 lines, -21 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +0 lines, -1 line 0 comments Download
M content/content_jni.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 6 chunks +3 lines, -6 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +0 lines, -148 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +0 lines, -166 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/battery_status/battery_status_dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +12 lines, -15 lines 0 comments Download
M content/renderer/battery_status/battery_status_dispatcher.cc View 1 2 3 4 5 13 1 chunk +19 lines, -31 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 3 chunks +30 lines, -24 lines 0 comments Download
M content/renderer/shared_memory_seqlock_reader.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/shared_memory_seqlock_reader.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/test/data/battery_status/battery_status_default_test.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/battery_status/battery_status_promise_resolution_test.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
A device/battery/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +90 lines, -0 lines 0 comments Download
A + device/battery/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
A + device/battery/OWNERS View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/battery/android/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +5 lines, -4 lines 0 comments Download
A device/battery/android/battery_jni_registrar.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +20 lines, -0 lines 0 comments Download
A device/battery/android/battery_jni_registrar.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +27 lines, -0 lines 0 comments Download
A + device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 3 chunks +3 lines, -3 lines 0 comments Download
A + device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -1 line 0 comments Download
A device/battery/battery.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +148 lines, -0 lines 0 comments Download
A device/battery/battery_export.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +29 lines, -0 lines 0 comments Download
A device/battery/battery_monitor.mojom View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
A device/battery/battery_monitor_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +34 lines, -0 lines 0 comments Download
A device/battery/battery_monitor_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +34 lines, -0 lines 0 comments Download
A + device/battery/battery_status.mojom View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -8 lines 0 comments Download
A + device/battery/battery_status_manager.h View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
A + device/battery/battery_status_manager_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +6 lines, -6 lines 0 comments Download
A + device/battery/battery_status_manager_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +6 lines, -6 lines 0 comments Download
A + device/battery/battery_status_manager_chromeos.cc View 1 2 3 4 5 6 6 chunks +22 lines, -50 lines 0 comments Download
A + device/battery/battery_status_manager_default.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
A + device/battery/battery_status_manager_linux.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -9 lines 0 comments Download
A + device/battery/battery_status_manager_linux.cc View 1 2 3 4 5 6 7 8 9 10 12 chunks +14 lines, -22 lines 0 comments Download
A + device/battery/battery_status_manager_linux_unittest.cc View 1 2 3 4 5 6 7 8 9 9 chunks +31 lines, -31 lines 0 comments Download
A + device/battery/battery_status_manager_mac.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 14 chunks +25 lines, -64 lines 0 comments Download
A + device/battery/battery_status_manager_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +8 lines, -8 lines 0 comments Download
A + device/battery/battery_status_manager_win.cc View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +16 lines, -42 lines 0 comments Download
A + device/battery/battery_status_manager_win_unittest.cc View 1 2 3 4 5 6 7 8 9 10 6 chunks +18 lines, -18 lines 0 comments Download
A + device/battery/battery_status_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +15 lines, -16 lines 0 comments Download
A + device/battery/battery_status_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +19 lines, -32 lines 0 comments Download
A + device/battery/battery_status_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 11 chunks +32 lines, -26 lines 0 comments Download
M device/device_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +15 lines, -1 line 0 comments Download
M mojo/common/handle_watcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
Here's what it looks like with the battery service moved to device/battery/. That code has ...
6 years, 4 months ago (2014-08-13 23:02:00 UTC) #1
timvolodine
On 2014/08/13 23:02:00, darin wrote: > Here's what it looks like with the battery service ...
6 years, 4 months ago (2014-08-14 17:58:19 UTC) #2
darin (slow to review)
6 years, 4 months ago (2014-08-14 19:37:16 UTC) #3
On 2014/08/14 17:58:19, timvolodine wrote:
...
> I think this looks great. It would significantly simplify the content/renderer
> code we currently have, especially if we move the other APIs to mojo at some
> point. Why is it that "std::numeric_limits<double>::infinity()" cannot be used
> in the .mojom file?

See https://code.google.com/p/chromium/issues/detail?id=402216. We just need
to teach the Mojom Parser to understand "inf" as a valid value for a double
field.

Powered by Google App Engine
This is Rietveld 408576698