content/browser/service_worker/service_worker_write_to_cache_job.h - Issue 457903002: After 24 hours, bust the browser cache when checking for ServiceWorker updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.h

Issue 457903002: After 24 hours, bust the browser cache when checking for ServiceWorker updates (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_storage_unittest.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job.h

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.h b/content/browser/service_worker/service_worker_write_to_cache_job.h

index 6833227c9f5cffa7fe1b265c79c1f2f9884e40f1..c11f84ebfadf96f2a10d868a3e4ad4c240d87879 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job.h

+++ b/content/browser/service_worker/service_worker_write_to_cache_job.h

@@ -40,9 +40,15 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob

ResourceType resource_type,

base::WeakPtr<ServiceWorkerContextCore> context,

ServiceWorkerVersion* version,

+ int extra_load_flags,

int64 response_id);

private:

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

+ UpdateBefore24Hours);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

+ UpdateAfter24Hours);

virtual ~ServiceWorkerWriteToCacheJob();

// net::URLRequestJob overrides

@@ -63,7 +69,7 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob

// Methods to drive the net request forward and

// write data to the disk cache.

- void InitNetRequest();

+ void InitNetRequest(int extra_load_flags);

void StartNetRequest();

net::URLRequestStatus ReadNetData(

net::IOBuffer* buf,