LayoutTests/http/tests/misc/favicon-loads-with-icon-loading-override.html - Issue 457893003: Remove unknown preferences errors in layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/misc/favicon-loads-with-icon-loading-override.html

Issue 457893003: Remove unknown preferences errors in layout tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-add testRunner.waitUntilDone() calls that were wrongly removed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <html>

2 <head>

3 <script>

4 function runTest()

5 {

6 if (window.testRunner) {

7 testRunner.dumpAsText();

8 testRunner.dumpResourceLoadCallbacks();

9 testRunner.setIconDatabaseEnabled(true);

10 testRunner.overridePreference("WebKitDisplayImagesKey", 0);

11 testRunner.overridePreference("WebKitLoadSiteIconsKey", 1);

12 testRunner.queueReload();

13 }

14 }

15 </script>

16 <link rel="icon" href="resources/favicon.ico" type="image/x-icon">

17 </head>

18 <body onload="runTest()">

19 https://bugs.webkit.org/show_bug.cgi?id=58292 - Provide new setting to allow sit e icon loading despite disabling automatic image loading in general.<br>

20 Resource load callbacks will reveal if the favicon still gets loaded if automati c image loading is disabled, but site icon image loading override is enabled. <b r>

21 </body>

22 </html>

OLD	NEW