Remove unknown preferences errors in layout tests

Remove unknown preferences errors in layout tests

This change removes all the following errors

CONSOLE MESSAGE: Invalid name for preference: foobar

by removing 2 tests that were the only users of some invalid
preference and removing some unneeded override in the css3/filters/
directory. It also adds a presubmit hooks so that we don't let
more errors creep into our tests.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180080

[Dirk Pranke, 2014-08-09 00:40:41]

lgtm w/ the one comment, below ...

https://codereview.chromium.org/457893003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/457893003/diff/1/PRESUBMIT.py#newcode320
PRESUBMIT.py:320: return [output_api.PresubmitError('Found an invalid preference
%s in expected result %s:%s' % (result.group(1), f, line_num))]
this bails out on the first error; it's perhaps better to find *all* errors that
might be there so that the user can correct them all at once.

[Julien - ping for review, 2014-08-11 15:57:55]

https://codereview.chromium.org/457893003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/457893003/diff/1/PRESUBMIT.py#newcode320
PRESUBMIT.py:320: return [output_api.PresubmitError('Found an invalid preference
%s in expected result %s:%s' % (result.group(1), f, line_num))]
On 2014/08/09 00:40:40, Dirk Pranke wrote:
> this bails out on the first error; it's perhaps better to find *all* errors
that
> might be there so that the user can correct them all at once.

Makes sense, changed to report all errors.

[Julien - ping for review, 2014-08-11 15:58:33]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-08-11 15:58:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/457893003/20001

[commit-bot: I haz the power, 2014-08-11 17:02:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19314)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22093)

[commit-bot: I haz the power, 2014-08-11 17:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 17:34:55]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[Julien - ping for review, 2014-08-11 21:28:34]

https://codereview.chromium.org/457893003/diff/20001/LayoutTests/css3/filters...
File LayoutTests/css3/filters/blur-filter-page-scroll.html (right):

https://codereview.chromium.org/457893003/diff/20001/LayoutTests/css3/filters...
LayoutTests/css3/filters/blur-filter-page-scroll.html:12:
window.testRunner.overridePreference("acceleratedCompositingEnabled", "0");
It turns out that this setting is not recognized by content_shell, that has a
white-list of known settings (that's different from settings.in).

I talked with enne about the best way forward and we should just remove these
overrides as there is no hardware acceleration involved in the tests (we checked
manually).

[Julien - ping for review, 2014-08-11 22:07:54]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-08-11 22:09:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/457893003/40001

[commit-bot: I haz the power, 2014-08-11 23:12:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19353)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22134)

[commit-bot: I haz the power, 2014-08-11 23:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 23:37:30]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[Julien - ping for review, 2014-08-12 16:10:22]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-08-12 16:11:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/457893003/60001

[commit-bot: I haz the power, 2014-08-12 16:29:52]

Change committed as 180080