Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4019)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java

Issue 457883002: Use Sync FakeServer in Android tests via custom APK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
index 768d33fda0a54f076290bdb3a1d4a6d0579a6156..02dddf9508e32262318fc57a1df339c312fd6e02 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
@@ -6,10 +6,11 @@ package org.chromium.chrome.browser.sync;
import android.accounts.Account;
import android.app.Activity;
+import android.test.suitebuilder.annotation.LargeTest;
import android.util.Log;
import org.chromium.base.ThreadUtils;
-import org.chromium.base.test.util.HostDrivenTest;
+import org.chromium.base.test.util.Feature;
import org.chromium.chrome.browser.identity.UniqueIdentificationGenerator;
import org.chromium.chrome.browser.identity.UniqueIdentificationGeneratorFactory;
import org.chromium.chrome.browser.identity.UuidBasedUniqueIdentificationGenerator;
@@ -65,10 +66,25 @@ public class SyncTest extends ChromeShellTestBase {
mSyncController = SyncController.get(mContext);
}
});
- SyncTestUtil.verifySyncServerIsRunning();
+ SyncTestUtil.useFakeServer(getInstrumentation().getTargetContext());
}
- @HostDrivenTest
+ @Override
+ protected void tearDown() throws Exception {
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
rlarocque 2014/08/09 01:19:59 tearDown() is not called on the UI thread? What t
Yaron 2014/08/12 17:22:03 These are called on a separate test thread (androi
+ @Override
+ public void run() {
+ mSyncController.stop();
+ SyncTestUtil.deleteFakeServer();
+ }
+ });
+
+ super.tearDown();
+ }
+
+
+ @LargeTest
+ @Feature({"Sync"})
public void testGetAboutSyncInfoYieldsValidData() throws Throwable {
setupTestAccountAndSignInToSync(FOREIGN_SESSION_TEST_MACHINE_ID);
@@ -86,7 +102,8 @@ public class SyncTest extends ChromeShellTestBase {
assertTrue("Couldn't get about info.", gotInfo);
}
- @HostDrivenTest
+ @LargeTest
+ @Feature({"Sync"})
public void testAboutSyncPageDisplaysCurrentSyncStatus() throws InterruptedException {
setupTestAccountAndSignInToSync(FOREIGN_SESSION_TEST_MACHINE_ID);
@@ -130,7 +147,8 @@ public class SyncTest extends ChromeShellTestBase {
hadExpectedStatus);
}
- @HostDrivenTest
+ @LargeTest
+ @Feature({"Sync"})
public void testDisableAndEnableSync() throws InterruptedException {
setupTestAccountAndSignInToSync(FOREIGN_SESSION_TEST_MACHINE_ID);
Account account =
@@ -146,6 +164,14 @@ public class SyncTest extends ChromeShellTestBase {
SyncTestUtil.verifySignedInWithAccount(mContext, account);
}
+ @LargeTest
+ @Feature({"Sync"})
+ public void testFakeServer() throws Exception {
+ // This test simply ensures the functionality of signing in and using FakeServer. It is
+ // unncessary once we have other enabled tests.
+ setupTestAccountAndSignInToSync(FOREIGN_SESSION_TEST_MACHINE_ID);
+ }
+
private void setupTestAccountAndSignInToSync(
final String syncClientIdentifier)
throws InterruptedException {

Powered by Google App Engine
This is Rietveld 408576698