chrome/android/shell/DEPS - Issue 457883002: Use Sync FakeServer in Android tests via custom APK

Side by Side Diff: chrome/android/shell/DEPS

Issue 457883002: Use Sync FakeServer in Android tests via custom APK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java ('k') | chrome/android/shell/chrome_main_delegate_chrome_shell_for_test_android.h » ('j') | chrome/android/shell/chrome_main_delegate_chrome_shell_for_test_android.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+chrome/app",	2 "+chrome/app",

3 "+chrome/browser",	3 "+chrome/browser",

4 "+components/dom_distiller/android/java",	4 "+components/dom_distiller/android/java",

5 "+components/search_engines",	5 "+components/search_engines",

6 "+content/public/android",	6 "+content/public/android",

7 "+content/public/browser",	7 "+content/public/browser",

8 "+content/public/browser/android",	8 "+content/public/browser/android",

9 "+printing/android",	9 "+printing/android",

10 "+sync/android/java/src/org/chromium/sync/notifier",	10 "+sync/android/java/src/org/chromium/sync/notifier",

11 "+sync/android/java/src/org/chromium/sync/signin",	11 "+sync/android/java/src/org/chromium/sync/signin",

	12 "+sync/test/fake_server/android",
	pval...(no longer on Chromium) 2014/08/09 00:48:21 I'm not sure where this code (fake_server_android. I'm not sure where this code (fake_server_android.{h,cc} exist in sync/test/fake_server/android) should go. They need to depend on the base FakeServer target (test_support_sync_fake_server). rlarocque 2014/08/09 01:19:59 I think the tendency is to not put it in a directo Show quoted text On 2014/08/09 00:48:21, pvalenzuela wrote: > I'm not sure where this code (fake_server_android.{h,cc} exist in > sync/test/fake_server/android) should go. They need to depend on the base > FakeServer target (test_support_sync_fake_server). I think the tendency is to not put it in a directory. sync/test/fake_server/fake_serve_android.cc would be my guess as to where it belongs. pval...(no longer on Chromium) 2014/08/12 01:21:35 This would introduce a dependency on a test direct Show quoted text On 2014/08/09 01:19:59, rlarocque wrote: > On 2014/08/09 00:48:21, pvalenzuela wrote: > > I'm not sure where this code (fake_server_android.{h,cc} exist in > > sync/test/fake_server/android) should go. They need to depend on the base > > FakeServer target (test_support_sync_fake_server). > > I think the tendency is to not put it in a directory. > sync/test/fake_server/fake_serve_android.cc would be my guess as to where it > belongs. This would introduce a dependency on a test directory though. I imagine this is not a preferred situation. Yaron 2014/08/12 17:22:03 I think we should keep these changes in a separate Show quoted text On 2014/08/12 01:21:35, pvalenzuela wrote: > On 2014/08/09 01:19:59, rlarocque wrote: > > On 2014/08/09 00:48:21, pvalenzuela wrote: > > > I'm not sure where this code (fake_server_android.{h,cc} exist in > > > sync/test/fake_server/android) should go. They need to depend on the base > > > FakeServer target (test_support_sync_fake_server). > > > > I think the tendency is to not put it in a directory. > > sync/test/fake_server/fake_serve_android.cc would be my guess as to where it > > belongs. > > This would introduce a dependency on a test directory though. I imagine this is > not a preferred situation. I think we should keep these changes in a separate package/folder that depends on chrome shell. So move all of the new code to: chrome/android/sync_test_shell ? (strawman) and you can add that dep there. pval...(no longer on Chromium) 2014/08/14 00:35:39 Done. Show quoted text On 2014/08/12 17:22:03, Yaron wrote: > On 2014/08/12 01:21:35, pvalenzuela wrote: > > On 2014/08/09 01:19:59, rlarocque wrote: > > > On 2014/08/09 00:48:21, pvalenzuela wrote: > > > > I'm not sure where this code (fake_server_android.{h,cc} exist in > > > > sync/test/fake_server/android) should go. They need to depend on the base > > > > FakeServer target (test_support_sync_fake_server). > > > > > > I think the tendency is to not put it in a directory. > > > sync/test/fake_server/fake_serve_android.cc would be my guess as to where it > > > belongs. > > > > This would introduce a dependency on a test directory though. I imagine this > is > > not a preferred situation. > > I think we should keep these changes in a separate package/folder that depends > on chrome shell. > So move all of the new code to: > chrome/android/sync_test_shell ? (strawman) and you can add that dep there. Done.
12 ]	13 ]

13	14

OLD	NEW