Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 457873003: PDF: Add some CHECKS to help debug a crash. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
gene
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

PDF: Add some CHECKS to help debug a crash. BUG=402035 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289822

Patch Set 1 #

Patch Set 2 : fix a check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-09 00:40:28 UTC) #1
gene
lgtm
6 years, 4 months ago (2014-08-11 18:59:37 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-11 19:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/457873003/1
6 years, 4 months ago (2014-08-11 19:17:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-11 23:54:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 02:40:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/5642) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/5651)
6 years, 4 months ago (2014-08-12 02:40:32 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-12 03:20:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/457873003/1
6 years, 4 months ago (2014-08-12 03:21:37 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 08:05:19 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 09:31:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/5797)
6 years, 4 months ago (2014-08-12 09:31:16 UTC) #12
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-15 00:39:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/457873003/20001
6 years, 4 months ago (2014-08-15 00:42:07 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 06:58:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (20001) as 289822
6 years, 4 months ago (2014-08-15 09:10:47 UTC) #16
Lei Zhang
6 years, 2 months ago (2014-09-26 23:23:45 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/607743005/ by thestig@chromium.org.

The reason for reverting is: No longer needed..

Powered by Google App Engine
This is Rietveld 408576698