Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 457863002: [Hotword] Update the version number of the component extension. (Closed)

Created:
6 years, 4 months ago by rpetterson
Modified:
6 years, 4 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Hotword] Update the version number of the component extension. Due to not updating the version number, the list of events listened for by the component extension was not being updated. Therefore, profiles who had been using hotwording for a while now were still listening for events on tab events and therefore opening the hotword helper on any all tab events. By updating the version number, it will overwrite the events list and the helper should now only wake up upon messages directed to it from our specified locations. I've jumped from 1 to 2 because in reality, that's about where we should be based on the number of changes since version 1.0. BUG=400579, 378844 TEST= 1) Run chrome with an old version such as 36. 2) In the Preferences file (<profile name>/Preferences) in the section named "dnhpdliibojhegemfjheidglijccjfmc", there should be a list named "events" which should look like: "events": [ "hotwordPrivate.onEnabledChanged", "tabs.onActivated", "tabs.onUpdated" ], 3) Now run the new version in the same profile directory. 4) In the same file and section as step 2, the "events" list should look like: "events": [ ] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/hotword_helper/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rpetterson
6 years, 4 months ago (2014-08-08 22:55:08 UTC) #1
James Hawkins
lgtm
6 years, 4 months ago (2014-08-11 14:12:54 UTC) #2
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 4 months ago (2014-08-11 17:03:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/457863002/1
6 years, 4 months ago (2014-08-11 17:05:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-11 20:47:05 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 11:56:15 UTC) #6
Message was sent while issue was closed.
Change committed as 288939

Powered by Google App Engine
This is Rietveld 408576698