telemetry: Pass systrace categories properly

telemetry: Pass systrace categories properly

Pass systrace categories to chrome_profiler as a comma separated single
argument instead of one argument per category. This fixes a bug where
only the first category was actually enabled.

We also set the output format to JSON because it's not necessary to wrap
the resulting systrace into a HTML container as we end up zipping the
result anyway.

TEST=tools/perf/run_benchmark smoothness.key_mobile_sites --browser=android-chrome --page-filter=linked --profiler=android-systrace

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289277

[tonyg, 2014-08-12 16:09:54]

lgtm

https://codereview.chromium.org/457823004/diff/1/tools/telemetry/telemetry/co...
File
tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py
(right):

https://codereview.chromium.org/457823004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py:29:
assert 'sched_wakeup' in z.open('systrace').read()
Since this is a unittest, we should be unittest assertions both here and above.

self.assertIn() works here and self.assertTrue() up on line 26.

[Sami, 2014-08-12 18:23:55]

https://codereview.chromium.org/457823004/diff/1/tools/telemetry/telemetry/co...
File
tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py
(right):

https://codereview.chromium.org/457823004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py:29:
assert 'sched_wakeup' in z.open('systrace').read()
On 2014/08/12 16:09:53, tonyg wrote:
> Since this is a unittest, we should be unittest assertions both here and
above.
> 
> self.assertIn() works here and self.assertTrue() up on line 26.

Ah, thanks for the tip. Methinks this should be a presubmit check :P

[Sami, 2014-08-12 18:23:58]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-08-12 18:27:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/457823004/20001

[commit-bot: I haz the power, 2014-08-12 22:27:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[commit-bot: I haz the power, 2014-08-13 00:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 00:10:00]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[Sami, 2014-08-13 10:30:51]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-08-13 10:31:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/457823004/40001

[commit-bot: I haz the power, 2014-08-13 12:25:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-13 13:09:03]

Change committed as 289277