Issue 457773002: Unable to scroll in Chrome system URLs(history,settings,extension) pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 457773002: Unable to scroll in Chrome system URLs(history,settings,extension) pages (Closed)

Created:
6 years, 4 months ago by abarth-chromium

Modified:
6 years, 4 months ago

Reviewers:
jamesr

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Unable to scroll in Chrome system URLs(history,settings,extension) pages This code was attempting to take the fast scrolling path for RenderViews that were not composited. Unfortunately, there's no way for the compositor to scroll RenderViews that are not composited. Instead, we should bail out and run the slow scrolling path. This CL also removes some dead code from this function and updates the comments to more accurately reflect reality. R=jamesr@chromium.org BUG=401878 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179875

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -22 lines)			Patch
M	LayoutTests/platform/mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/platform/win/fast/repaint/repaint-during-scroll-with-zoom-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	3 chunks	+8 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/457773002/1

6 years, 4 months ago (2014-08-08 22:41:36 UTC) #4

Message was sent while issue was closed.

Change committed as 179875

Expand Messages | Collapse Messages