Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 457723002: Polish signin confirmation bubble (Closed)

Created:
6 years, 4 months ago by guohui
Modified:
6 years, 4 months ago
Reviewers:
noms (inactive), sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Polish signin confirmation bubble - wrap the title text - removes the extra single pixel white border at the top. BUG=401817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288471

Patch Set 1 #

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
guohui
Hey Monica, could you please review the CL? Thanks, Hui
6 years, 4 months ago (2014-08-08 17:18:07 UTC) #1
noms (inactive)
lgtm
6 years, 4 months ago (2014-08-08 17:19:50 UTC) #2
guohui
+sky for owner review. Thanks!
6 years, 4 months ago (2014-08-08 17:20:14 UTC) #3
sky
LGTM
6 years, 4 months ago (2014-08-08 19:15:42 UTC) #4
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-08 19:17:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/457723002/20001
6 years, 4 months ago (2014-08-08 19:20:59 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 23:53:11 UTC) #7
Message was sent while issue was closed.
Change committed as 288471

Powered by Google App Engine
This is Rietveld 408576698