Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2254)

Unified Diff: Source/modules/credentialmanager/Credential.h

Issue 457683002: Credential Manager: Add platform-exposed Credential objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/credentialmanager/Credential.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/credentialmanager/Credential.h
diff --git a/Source/modules/credentialmanager/Credential.h b/Source/modules/credentialmanager/Credential.h
index 38889e5797a72b9a3ab73c473ef1541c49f4c166..c590cb84be9ab68814b8ec335bb5c43fbc8a1f24 100644
--- a/Source/modules/credentialmanager/Credential.h
+++ b/Source/modules/credentialmanager/Credential.h
@@ -7,29 +7,29 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/core/v8/SerializedScriptValue.h"
+#include "platform/credentialmanager/PlatformCredential.h"
#include "platform/heap/Handle.h"
namespace blink {
-class Credential : public GarbageCollectedFinalized<Credential>, public ScriptWrappable {
+class WebCredential;
+
+class Credential : public GarbageCollected<Credential>, public ScriptWrappable {
public:
static Credential* create(const String& id, const String& name, const String& avatarURL);
- virtual ~Credential();
// Credential.idl
- const String& id() const { return m_id; }
- const String& name() const { return m_name; }
- const String& avatarURL() const { return m_avatarURL; }
+ const String& id() const { return m_platformCredential->id(); }
+ const String& name() const { return m_platformCredential->name(); }
+ const String& avatarURL() const { return m_platformCredential->avatarURL(); }
- virtual void trace(Visitor*) { };
+ virtual void trace(Visitor*);
protected:
+ explicit Credential(PlatformCredential*);
Credential(const String& id, const String& name, const String& avatarURL);
-private:
- String m_id;
- String m_name;
- String m_avatarURL;
+ Member<PlatformCredential> m_platformCredential;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/modules/credentialmanager/Credential.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698