Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5151)

Unified Diff: chrome/test/data/extensions/api_test/extension_options/embed_self/test.js

Issue 457653003: Implement <extensionoptions> deferred attach logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
diff --git a/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js b/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
index 69a8a6999fc211df288b7d9b20f1f7500b0b034a..892c431a6d923ca839d6b79deb2f4326dfa9d0be 100644
--- a/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
+++ b/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
@@ -47,6 +47,22 @@ chrome.test.runTests([
document.body.appendChild(extensionoptions);
},
+ function createGuestViewDeferredAttach() {
+ var extensionoptions = new ExtensionOptions();
+ extensionoptions.onload = function() {
+ try {
+ chrome.test.assertTrue(optionsPageLoaded());
+ chrome.test.succeed();
+ } finally {
+ document.body.removeChild(extensionoptions);
+ }
+ };
+ extensionoptions.extension = chrome.runtime.id;
+ setTimeout(function() {
+ document.body.appendChild(extensionoptions);
+ }, 1000);
not at google - send to devlin 2014/08/12 19:58:29 Why 1000? Just make it 0, no need to make this tes
ericzeng 2014/08/12 21:53:33 Unfortunately I need a small delay in order to rep
+ },
+
// Tests if the <extensionoptions> guest view is successfully created and can
// communicate with the embedder. This test expects that the guest options
// page will add a {'pass': true} property to every Window and fire the

Powered by Google App Engine
This is Rietveld 408576698