Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 457653002: Revert 179762 "Allow paint invalidation containers to cross fram..." (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert 179762 "Allow paint invalidation containers to cross fram..." This CL broke browser_tests::MalwareDOMDetailsTest.Everything http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=browser_tests&tests=MalwareDOMDetailsTest.Everything http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/682/steps/browser_tests/logs/stdio > Allow paint invalidation containers to cross frame boundaries. > > Previously, the *actual* paint invalidation container, meaning the enclosing > compositing layer / root RenderView, could already have been across a frame boundary. The logic to do this correctly was done via special code in RenderView. > > Instead, generalize the existing mechanisms to find a paint invalidation container > and map rects to repaint container coordinate space to cross frame boundaries. > This simplifies the code, and also causes paint invalidation rects to always be stored > in the coordinate space of their graphics layer backing. The latter is important if we want > to use these rects for determining which parts of a graphics layer need to be painted. > > BUG=401156 > > Review URL: https://codereview.chromium.org/445793002 TBR=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -52 lines) Patch
M trunk/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/rendering/RenderLayerRepainter.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M trunk/Source/core/rendering/RenderObject.h View 1 chunk +4 lines, -1 line 0 comments Download
M trunk/Source/core/rendering/RenderObject.cpp View 5 chunks +11 lines, -20 lines 0 comments Download
M trunk/Source/core/rendering/RenderView.cpp View 5 chunks +25 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haraken
6 years, 4 months ago (2014-08-08 10:56:48 UTC) #1
haraken
Committed patchset #1 manually as r179816.
6 years, 4 months ago (2014-08-08 10:56:58 UTC) #2
haraken
6 years, 4 months ago (2014-08-08 10:57:42 UTC) #3
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698