Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 45763005: NaCl: Update revision in DEPS, r12321 -> r12352 (Closed)

Created:
7 years, 1 month ago by Mark Seaborn
Modified:
7 years, 1 month ago
Reviewers:
bradn
CC:
chromium-reviews, bradn, bsy, Derek Schuff, JF, Mark Mentovai, Roland McGrath, native-client-reviews_googlegroups.com, sehr (please use chromium), Jim Stichnoth
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r12321 -> r12352 This pulls in the following Native Client changes: r12322: (dschuff) Build binutils with toolchain_build.py infrastructure r12323: (stichnot) Add a --retries=<N> flag, for flaky test environments. r12324: (dschuff) Add gyp_nacl.py to make gyp_nacl importable on python 2.6 r12325: (bradnelson) Incorporate gcc version string into toolchain_build platform string. r12326: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS for SJLJ EH change r12327: (dschuff) Revert "Build binutils with toolchain_build.py infrastructure" r12328: (mseaborn) PNaCl: Update GCC revision in pnacl/DEPS for SJLJ EH change r12329: (bsy) hook up pwrite/pread syscalls. untrusted pwrite/pread test. r12330: (sehr) Remove combreloc from configuration, to avoid an assertion failure in the dynamic loader r12331: (jfb) Allow SPEC2k to be run unsandboxed with LLVM. r12332: (stichnot) Update llvm_test_suite DEPS to get improved testsuite. r12333: (sehr) Change build to use new binutils r12334: (dschuff) Port PNaCl x86 main waterfall buildbots to buildbot_lib r12335: (dschuff) Fix bot breakage in r12334 and remove obsolete PNaCl bots from buildbot_selector.py r12336: (dschuff) Build binutils with toolchain_build.py infrastructure r12337: (dschuff) Set some default configuration values in buildbot_lib's Context ctor r12338: (dschuff) Use new format for PNaCl component revisions. r12339: (dschuff) PNaCl FYI bot script: explicitly setup newlib nacl headers r12340: (dschuff) Update TOOL_REVISIONS for PNaCl 12274->12331 r12341: (stichnot) Remove two ARM known failures. r12342: (mark) Run strip via xcrun. r12343: (mseaborn) pnacl-translate: Remove "-shared" and "-static" options r12344: (dschuff) Remove obsolete bots from buildbot_selector.py r12345: (dschuff) Fix buildbot_selector.py's disabling of gyp builds on some bots r12346: (mseaborn) PNaCl: Add script for updating the Git revisions in pnacl/COMPONENT_REVISIONS r12347: (dschuff) Fix pnacl COMPONENT_REVISIONS to match what was in DEPS in r12337 r12348: (mseaborn) PNaCl: Remove some tests' uses of "-nostdlib" in TRANSLATEFLAGS r12349: (mcgrathr) Update binutils revision in tools/REVISIONS r12350: (mseaborn) pnacl-ld: Remove "-shared" option and make "-rpath-link" a no-op r12351: (mseaborn) PNaCl: Remove unused file, pnacl/scripts/libgcc-glibc.mvars r12352: (mseaborn) pnacl-clang: Remove "-shared" and "-dynamic" options BUG=none TEST=browser_tests and nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Seaborn
The Chromium trybots have become very flaky in recent weeks. I intend to commit this ...
7 years, 1 month ago (2013-11-04 23:39:24 UTC) #1
bradn
lgtm
7 years, 1 month ago (2013-11-04 23:54:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/45763005/1
7 years, 1 month ago (2013-11-05 00:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/45763005/1
7 years, 1 month ago (2013-11-05 00:43:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/45763005/1
7 years, 1 month ago (2013-11-05 03:03:11 UTC) #5
commit-bot: I haz the power
Change committed as 232933
7 years, 1 month ago (2013-11-05 06:58:26 UTC) #6
Mark Seaborn
7 years, 1 month ago (2013-11-05 15:50:45 UTC) #7
Message was sent while issue was closed.
This caused a size regression,
https://code.google.com/p/chromium/issues/detail?id=315063, probably due to:

r12329: (bsy) hook up pwrite/pread syscalls. untrusted pwrite/pread test.

Powered by Google App Engine
This is Rietveld 408576698