Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 457563002: Remove unused DBusThreadManagerObserver (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove unused DBusThreadManagerObserver BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289254

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M chromeos/dbus/dbus_thread_manager.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 5 chunks +0 lines, -19 lines 0 comments Download
D chromeos/dbus/dbus_thread_manager_observer.h View 1 chunk +0 lines, -26 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.h View 4 chunks +0 lines, -9 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.cc View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-08 07:15:56 UTC) #1
hashimoto
satorux@, could you take a look at this change?
6 years, 4 months ago (2014-08-12 08:36:23 UTC) #2
satorux1
LGTM. Nice! Sorry for the belated response.
6 years, 4 months ago (2014-08-13 04:01:33 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-13 04:28:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/457563002/20001
6 years, 4 months ago (2014-08-13 04:29:06 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 10:17:16 UTC) #6
Message was sent while issue was closed.
Change committed as 289254

Powered by Google App Engine
This is Rietveld 408576698