Issue 457553002: Skip -pedantic for GTest as long as we -std=gnu++0x.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 457553002: Skip -pedantic for GTest as long as we -std=gnu++0x. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	test/base-unittests/base-unittests.gyp	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM, although the *real* underlying reason is that we still need to support GCC 4.6, ...

6 years, 4 months ago (2014-08-08 06:59:00 UTC) #2

Benedikt Meurer

6 years, 4 months ago (2014-08-08 06:59:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 22986 (tree was closed).