Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: ui/base/resource/resource_bundle.cc

Issue 45753004: ui: Repack resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: less crazyness Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/ui_resources.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/resource/resource_bundle.cc
diff --git a/ui/base/resource/resource_bundle.cc b/ui/base/resource/resource_bundle.cc
index a6185bc4f5e53bcc2490aa699819d645bde3740c..92234cbf1f7be0b4526a310e7d5a7688aedd00e8 100644
--- a/ui/base/resource/resource_bundle.cc
+++ b/ui/base/resource/resource_bundle.cc
@@ -289,17 +289,15 @@ std::string ResourceBundle::LoadLocaleResources(
void ResourceBundle::LoadTestResources(const base::FilePath& path,
const base::FilePath& locale_path) {
// Use the given resource pak for both common and localized resources.
- scoped_ptr<DataPack> data_pack(
- new DataPack(SCALE_FACTOR_100P));
+ scoped_ptr<DataPack> data_pack(new DataPack(SCALE_FACTOR_100P));
if (!path.empty() && data_pack->LoadFromPath(path))
AddDataPack(data_pack.release());
- data_pack.reset(new DataPack(ui::SCALE_FACTOR_NONE));
+ data_pack.reset(new DataPack(ui::SCALE_FACTOR_100P));
tfarina 2013/11/07 00:05:46 does this sounds more reasonable? is it ok if it p
tony 2013/11/07 18:13:37 I think this is OK. Why does this work? It doesn
tfarina 2013/11/09 00:24:35 Yeah, it does not seem to matter. The failing unit
if (!locale_path.empty() && data_pack->LoadFromPath(locale_path)) {
locale_resources_data_.reset(data_pack.release());
} else {
- locale_resources_data_.reset(
- new DataPack(ui::SCALE_FACTOR_NONE));
+ locale_resources_data_.reset(new DataPack(ui::SCALE_FACTOR_NONE));
}
}
« no previous file with comments | « no previous file | ui/ui_resources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698