Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 457523004: DevTools: Make GC button in timeline to fire gc events in all targets (Closed)

Created:
6 years, 4 months ago by sergeyv
Modified:
6 years, 4 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Make GC button in timeline to fire gc events in all targets BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sergeyv
6 years, 4 months ago (2014-08-12 09:25:53 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-12 11:58:48 UTC) #2
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-13 05:45:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/457523004/1
6 years, 4 months ago (2014-08-13 05:45:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 06:43:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 06:47:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7256)
6 years, 4 months ago (2014-08-13 06:47:17 UTC) #7
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-13 07:02:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/457523004/1
6 years, 4 months ago (2014-08-13 07:03:13 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 07:12:40 UTC) #10
Message was sent while issue was closed.
Change committed as 180148

Powered by Google App Engine
This is Rietveld 408576698