Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 457503002: Reland "Add initial support for compiler unit tests using GTest/GMock.". (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Add initial support for compiler unit tests using GTest/GMock.". LOG=y BUG=v8:3489 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22987

Patch Set 1 #

Patch Set 2 : Workaround for -std=gnu++0x. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -8 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/base-unittests/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A test/compiler-unittests/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A test/compiler-unittests/arm/instruction-selector-arm-unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A test/compiler-unittests/compiler-unittests.h View 1 chunk +60 lines, -0 lines 0 comments Download
A test/compiler-unittests/compiler-unittests.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A test/compiler-unittests/compiler-unittests.gyp View 1 1 chunk +58 lines, -0 lines 0 comments Download
A + test/compiler-unittests/compiler-unittests.status View 0 chunks +-1 lines, --1 lines 0 comments Download
A test/compiler-unittests/instruction-selector-unittest.h View 1 chunk +137 lines, -0 lines 0 comments Download
A test/compiler-unittests/instruction-selector-unittest.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A + test/compiler-unittests/testcfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/presubmit.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-08 05:50:51 UTC) #1
Sven Panne
lgtm
6 years, 4 months ago (2014-08-08 07:03:42 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-08 07:04:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 22987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698