Source/bindings/scripts/v8_utilities.py - Issue 457483002: Blink-in-JS: Support partial interfaces in private scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 457483002: Blink-in-JS: Support partial interfaces in private scripts Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_utilities.py

diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py

index 674a1b8d9969b08a53404147c1c7e289db1f73f4..478cded6e225d112ebac93168bca72f2fd02afc2 100644

--- a/Source/bindings/scripts/v8_utilities.py

+++ b/Source/bindings/scripts/v8_utilities.py

@@ -117,6 +117,8 @@ IdlType.enum_validation_expression = property(enum_validation_expression)

def scoped_name(interface, definition, base_name):

+ if 'ImplementedInPrivateScript' in definition.extended_attributes:

+ return '%s::%s' % (v8_class_name(interface), base_name)

# partial interfaces are implemented as separate classes, with their members

# implemented as static member functions

partial_interface_implemented_as = definition.extended_attributes.get('PartialInterfaceImplementedAs')

@@ -125,8 +127,6 @@ def scoped_name(interface, definition, base_name):

if (definition.is_static or

definition.name in ('Constructor', 'NamedConstructor')):

return '%s::%s' % (cpp_name(interface), base_name)

- if 'ImplementedInPrivateScript' in definition.extended_attributes:

- return '%s::%s' % (v8_class_name(interface), base_name)

return 'impl->%s' % base_name