Source/bindings/scripts/v8_attributes.py - Issue 457483002: Blink-in-JS: Support partial interfaces in private scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 457483002: Blink-in-JS: Support partial interfaces in private scripts Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 3f3b3f649d2389ced02c1b1a389dadd7adada875..6b3b1a110e9fb81882ccc226ca88d6944e33790e 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -233,6 +233,7 @@ def getter_expression(interface, attribute, context):

# static member functions, which for instance members (non-static members)

# take *impl as their first argument

if ('PartialInterfaceImplementedAs' in attribute.extended_attributes and

+ not 'ImplementedInPrivateScript' in attribute.extended_attributes and

not attribute.is_static):

arguments.append('*impl')

if attribute.idl_type.is_explicit_nullable:

@@ -361,6 +362,7 @@ def setter_expression(interface, attribute, context):

# static member functions, which for instance members (non-static members)

# take *impl as their first argument

if ('PartialInterfaceImplementedAs' in extended_attributes and

+ not 'ImplementedInPrivateScript' in extended_attributes and

not attribute.is_static):

arguments.append('*impl')

idl_type = attribute.idl_type