Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 457443002: Remove unnecessary pixel expectations (platform/win) (Closed)

Created:
6 years, 4 months ago by Xianzhu
Modified:
6 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Remove unnecessary pixel expectations (platform/win) The pixel expectations existed when the tests were pixel tests but now the tests are text-only tests. TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179859

Patch Set 1 #

Patch Set 2 : Restore false-positives #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
D LayoutTests/platform/win/compositing/geometry/clipped-video-controller-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/css3/flexbox/repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/css3/flexbox/repaint-rtl-column-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/execCommand/boldSelection-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/inserting/insert-before-link-1-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/pasteboard/5245519-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/positioning/complex-percentage-height-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/css/nested-layers-with-hover-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/css/remove-shorthand-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/dynamic/insertAdjacentElement-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/events/keydown-1-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/events/touch/touch-target-removed-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/8250-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/frames/frame-set-same-location-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/frames/frame-set-same-src-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/lists/item-not-in-list-line-wrapping-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/negativeColumnWidth-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/zeroColumnCount-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/4776765-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/add-table-overpaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/background-generated-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/background-misaligned-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/backgroundSizeRepaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/block-layout-inline-children-float-positioned-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/block-layout-inline-children-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/block-no-inflow-children-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/body-background-image-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/border-fit-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/border-radius-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/border-repaint-glitch-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/box-shadow-dynamic-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/box-shadow-inset-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/bugzilla-3509-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/bugzilla-5699-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/bugzilla-6278-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/bugzilla-6388-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/bugzilla-6473-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/bugzilla-7235-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/canvas-putImageData-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/caret-outside-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/caret-with-transformation-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/change-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/child-of-sub-pixel-offset-composited-layer-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/clipped-relative-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/containing-block-position-change-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/content-into-overflow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/control-clip-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/create-layer-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/delete-into-nested-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/dynamic-table-vertical-alignment-change-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-and-absolute-position-scrolled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-child-move-after-scroll-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-move-after-scroll-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-position-transparency-with-overflow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/fixed-tranformed-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/float-move-during-layout-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/float-new-in-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/float-overflow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/float-overflow-right-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/gradients-em-stops-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/hover-pseudo-borders-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/inline-color-change-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/inline-outline-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/intermediate-layout-position-clip-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/intermediate-layout-position-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/invisible-objects-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/japanese-rl-selection-clear-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/japanese-rl-selection-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/layout-state-only-positioned-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/layout-state-relative-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/layout-state-scrolloffset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/layout-state-scrolloffset2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/layout-state-scrolloffset3-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-1-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-10-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-3-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-4-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-5-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-6-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-7-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-8-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-flow-with-floats-9-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-in-scrolled-clipped-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/line-overflow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/lines-with-layout-delta-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/list-marker-2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/make-children-non-inline-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/mix-blend-mode-separate-stacking-context-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/multicol-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/opacity-change-on-overflow-float-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/outline-child-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/outline-inset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/outline-repaint-glitch-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/outline-shrinking-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-delete-line-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-flipped-writing-mode-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-hide-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-into-content-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-scroll-body-appear-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-scroll-delete-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/overflow-show-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/positioned-document-element-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/reflection-redraw-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/reflection-repaint-test-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/rel-positioned-inline-with-overflow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/repaint-during-scroll-with-zoom-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/repaint-resized-overflow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-absolute-layer-with-reflection-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-fixed-layer-with-reflection-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-fixed-reflected-layer-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-in-clipped-layer-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-in-fixed-layer-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-in-transformed-layer-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-inside-table-cell-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/scroll-with-transformed-parent-layer-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/search-field-cancel-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/select-option-background-color-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/selected-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-after-delete-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-after-remove-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-clear-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-gap-overflow-scroll-2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-gap-overflow-scroll-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/selection-rl-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/stacked-diacritics-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/static-to-positioned-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/subtree-layoutstate-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/subtree-root-skipped-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-cell-collapsed-border-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-cell-move-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-collapsed-border-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-extra-bottom-grow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-outer-border-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-section-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/table-two-pass-layout-overpaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/text-append-dirty-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/text-selection-rect-in-overflow-2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/text-selection-rect-in-overflow-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-absolute-child-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-absolute-in-positioned-container-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-disable-layoutstate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-layout-repaint-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-relative-position-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-repaint-descendants-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-replaced-shadows-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-rotate-and-remove-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/transform-translate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/http/tests/incremental/slow-utf8-css-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/http/tests/ssl/verify-ssl-enabled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/xhr-to-blob-in-isolated-world-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/custom/baseval-animval-equality-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/custom/image-clipped-hit-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/dom/SVGLengthList-basics-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/dom/SVGNumberList-basics-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/dom/SVGPointList-basics-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/dom/SVGTransformList-basics-expected.png View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
Xianzhu
6 years, 4 months ago (2014-08-08 01:28:46 UTC) #1
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-08 19:00:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/457443002/20001
6 years, 4 months ago (2014-08-08 19:03:03 UTC) #3
Dirk Pranke
lgtm
6 years, 4 months ago (2014-08-08 19:22:14 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 19:36:21 UTC) #5
Message was sent while issue was closed. 
Change committed as 179859

Powered by Google App Engine
This is Rietveld 408576698