Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 457343003: Disable code generation in tests that use GraphBuilderTester on platforms that have no TF backend. (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Disable code generation in tests that use GraphBuilderTester on platforms that have no TF backend. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/compiler/graph-builder-tester.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 4 months ago (2014-08-11 14:49:17 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-12 07:57:36 UTC) #2
titzer
6 years, 4 months ago (2014-08-12 08:06:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698