Consider index8 a compressed config.

Consider index8 a compressed config.

Committed: https://skia.googlesource.com/skia/+/d4cb922ea1a85d381e88975b63664f6c0bf28cdb

[robertphillips, 2014-08-11 21:02:07]

lgtm + suggestion

https://codereview.chromium.org/457333004/diff/60001/include/gpu/GrTypes.h
File include/gpu/GrTypes.h (right):

https://codereview.chromium.org/457333004/diff/60001/include/gpu/GrTypes.h#ne...
include/gpu/GrTypes.h:680: SkASSERT(GrPixelConfigIsCompressed(config));
"// sizeof(GrColor)" -> "// 4 == sizeof(GrColor)" ?

[krajcevski, 2014-08-11 21:02:52]

lgtm, too

https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (left):

https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp#o...
src/gpu/gl/GrGpuGL.cpp:2753: kIndex_8_GrPixelConfig != src->config() &&
Does this function need a check for compressed textures? (Or perhaps some
asserts)

[bsalomon, 2014-08-11 21:04:12]

https://codereview.chromium.org/457333004/diff/60001/include/gpu/GrTypes.h
File include/gpu/GrTypes.h (right):

https://codereview.chromium.org/457333004/diff/60001/include/gpu/GrTypes.h#ne...
include/gpu/GrTypes.h:680: SkASSERT(GrPixelConfigIsCompressed(config));
On 2014/08/11 21:02:07, robertphillips wrote:
> "// sizeof(GrColor)" -> "// 4 == sizeof(GrColor)" ?

Done.

[bsalomon, 2014-08-11 21:05:53]

https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (left):

https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp#o...
src/gpu/gl/GrGpuGL.cpp:2753: kIndex_8_GrPixelConfig != src->config() &&
On 2014/08/11 21:02:51, krajcevski wrote:
> Does this function need a check for compressed textures? (Or perhaps some
> asserts)

I'll add an assert. I expect that isConfigRenderable() will return false for any
compressed config.

[krajcevski, 2014-08-11 21:06:23]

On 2014/08/11 21:05:53, bsalomon wrote:
> https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp
> File src/gpu/gl/GrGpuGL.cpp (left):
> 
>
https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp#o...
> src/gpu/gl/GrGpuGL.cpp:2753: kIndex_8_GrPixelConfig != src->config() &&
> On 2014/08/11 21:02:51, krajcevski wrote:
> > Does this function need a check for compressed textures? (Or perhaps some
> > asserts)
> 
> I'll add an assert. I expect that isConfigRenderable() will return false for
any
> compressed config.

Yes, it should.

[bsalomon, 2014-08-11 21:08:02]

https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (left):

https://codereview.chromium.org/457333004/diff/60001/src/gpu/gl/GrGpuGL.cpp#o...
src/gpu/gl/GrGpuGL.cpp:2753: kIndex_8_GrPixelConfig != src->config() &&
On 2014/08/11 21:05:53, bsalomon wrote:
> On 2014/08/11 21:02:51, krajcevski wrote:
> > Does this function need a check for compressed textures? (Or perhaps some
> > asserts)
> 
> I'll add an assert. I expect that isConfigRenderable() will return false for
any
> compressed config.

Oh wait, there's already a check on the next line.

[bsalomon, 2014-08-11 21:08:09]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-08-11 21:08:33]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/457333004/80001

[commit-bot: I haz the power, 2014-08-11 21:19:14]

Change committed as d4cb922ea1a85d381e88975b63664f6c0bf28cdb