Source/core/rendering/svg/RenderSVGShape.cpp - Issue 45733010: Add pointer-events="bounding-box" for svg content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGShape.cpp

Issue 45733010: Add pointer-events="bounding-box" for svg content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: make assert more specific Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGShape.cpp

diff --git a/Source/core/rendering/svg/RenderSVGShape.cpp b/Source/core/rendering/svg/RenderSVGShape.cpp

index 9ea30e9b8251772c787fbd98e7ea5169fc5be4ac..04298f7e49d8d64694ea67ec3e81445086a2af21 100644

--- a/Source/core/rendering/svg/RenderSVGShape.cpp

+++ b/Source/core/rendering/svg/RenderSVGShape.cpp

@@ -338,7 +338,8 @@ bool RenderSVGShape::nodeAtFloatPointInternal(const HitTestRequest& request, con

WindRule fillRule = svgStyle->fillRule();

if (request.svgClipContent())

fillRule = svgStyle->clipRule();

- if ((hitRules.canHitStroke && (svgStyle->hasStroke() || !hitRules.requireStroke) && strokeContains(localPoint, hitRules.requireStroke))

+ if ((hitRules.canHitBoundingBox && objectBoundingBox().contains(localPoint))

+ || (hitRules.canHitStroke && (svgStyle->hasStroke() || !hitRules.requireStroke) && strokeContains(localPoint, hitRules.requireStroke))

|| (hitRules.canHitFill && (svgStyle->hasFill() || !hitRules.requireFill) && fillContains(localPoint, hitRules.requireFill, fillRule)))

return true;

}