Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: Source/core/rendering/svg/RenderSVGContainer.cpp

Issue 45733010: Add pointer-events="bounding-box" for svg content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/RenderSVGContainer.cpp
diff --git a/Source/core/rendering/svg/RenderSVGContainer.cpp b/Source/core/rendering/svg/RenderSVGContainer.cpp
index f9a9bf16c9a72b02a413a2f7c748f10851711242..4e4c65a892f80c03e9372df08a4647c9cad2e899 100644
--- a/Source/core/rendering/svg/RenderSVGContainer.cpp
+++ b/Source/core/rendering/svg/RenderSVGContainer.cpp
@@ -185,6 +185,13 @@ bool RenderSVGContainer::nodeAtFloatPoint(const HitTestRequest& request, HitTest
// Spec: Only graphical elements can be targeted by the mouse, period.
pdr. 2013/11/01 03:42:00 We should remove this comment now.
Erik Dahlström (inactive) 2013/11/29 16:30:48 Done.
// 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispatched."
pdr. 2013/11/01 03:42:00 Can you move this comment above "return false;"?
Erik Dahlström (inactive) 2013/11/29 16:30:48 Done.
+
+ // pointer-events=boundingBox makes it possible for containers to be direct targets
pdr. 2013/11/01 03:42:00 Can you add an assert here that the object boundin
Erik Dahlström (inactive) 2013/11/29 16:30:48 Done.
+ if (style()->pointerEvents() == PE_BOUNDINGBOX && objectBoundingBox().contains(localPoint)) {
+ updateHitTestResult(result, roundedLayoutPoint(localPoint));
+ return true;
+ }
+
return false;
}

Powered by Google App Engine
This is Rietveld 408576698