Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: chromeos/ime/ibus_bridge.h

Issue 45733008: sk6_charactercomposer: Merged DispatchKeyEvent and its fabricated version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/ibus_bridge.h
diff --git a/chromeos/ime/ibus_bridge.h b/chromeos/ime/ibus_bridge.h
index 57799ec1476bd5752cf4d24673446cbf55b998fa..2b6a3d3e58f51476f5fe545fe842379699bc178d 100644
--- a/chromeos/ime/ibus_bridge.h
+++ b/chromeos/ime/ibus_bridge.h
@@ -86,15 +86,23 @@ class CHROMEOS_EXPORT IBusEngineHandlerInterface {
// Called when the IME is reset.
virtual void Reset() = 0;
- // Called when the key event is received. The |keycode| is raw layout
- // independent keycode. The |keysym| is result of XLookupString function
- // which translate |keycode| to keyboard layout dependent symbol value.
- // Actual implementation must call |callback| after key event handling.
- // For example: key press event for 'd' key on us layout and dvorak layout.
+ // Called when the key event is received. The |keycode| is raw
+ // layout independent keycode string. The |keysym| is a keyboard
+ // layout dependent symbol string. Actual implementation must call
+ // |callback| after key event handling. For example: key press
+ // event for 'd' key on us layout and dvorak layout.
// keyval keycode state
- // us layout : 0x64 0x20 0x00
- // dvorak layout : 0x65 0x20 0x00
- virtual void ProcessKeyEvent(uint32 keysym, uint32 keycode, uint32 state,
+ // us layout : "d" "KeyD" 0x00
+ // dvorak layout : "e" "KeyD" 0x00
+ //
+ // TODO(komatsu): Use ui::KeyEvent after addressing the DEPS issue.
+ virtual void ProcessKeyEvent(const std::string& keysym,
+ const std::string& keycode,
+ bool is_key_down,
+ bool is_alt_down,
+ bool is_ctrl_down,
+ bool is_shift_down,
+ bool is_caps_lock_down,
const KeyEventDoneCallback& callback) = 0;
// Called when the candidate in lookup table is clicked. The |index| is 0
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_ibus_browserttests.cc ('k') | chromeos/ime/mock_ime_engine_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698