Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 457313003: Reland "MIPS: Add support for arch. revision 6 to mips32 port." (Closed)

Created:
6 years, 4 months ago by dusmil.imgtec
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "MIPS: Add support for arch. revision 6 to mips32 port." Original commit r23028 breaks ARM64 build due to conflicting FP64 symbolic constant definition in src/globals.h and src/arm64/constants-arm64.h. TEST= BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=23050

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2481 lines, -494 lines) Patch
M build/toolchain.gypi View 5 chunks +99 lines, -1 line 0 comments Download
M src/base/atomicops_internals_mips_gcc.h View 3 chunks +19 lines, -18 lines 0 comments Download
M src/base/cpu.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/assembler-mips.h View 9 chunks +134 lines, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 28 chunks +470 lines, -44 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +22 lines, -10 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/constants-mips.h View 14 chunks +124 lines, -4 lines 0 comments Download
M src/mips/constants-mips.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M src/mips/disasm-mips.cc View 18 chunks +360 lines, -48 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 15 chunks +17 lines, -28 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 4 chunks +31 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 26 chunks +433 lines, -74 lines 0 comments Download
M src/mips/simulator-mips.h View 2 chunks +10 lines, -4 lines 0 comments Download
M src/mips/simulator-mips.cc View 33 chunks +489 lines, -144 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 8 chunks +79 lines, -56 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 4 chunks +138 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dusmil.imgtec
6 years, 4 months ago (2014-08-11 11:56:20 UTC) #1
Jakob Kummerow
LGTM (only looked at globals.h)
6 years, 4 months ago (2014-08-11 11:57:52 UTC) #2
Jakob Kummerow
Btw, best practice is to upload the original CL as patch set 1, then the ...
6 years, 4 months ago (2014-08-11 12:00:37 UTC) #3
dusmil.imgtec
Right, thank you for suggestions. To clarify differences between original and this CL, the only ...
6 years, 4 months ago (2014-08-11 12:52:50 UTC) #4
paul.l...
LGTM.
6 years, 4 months ago (2014-08-11 13:55:29 UTC) #5
jochen (gone - plz use gerrit)
please run "make qc" before committing
6 years, 4 months ago (2014-08-11 14:12:18 UTC) #6
dusmil.imgtec
Done, no failures.
6 years, 4 months ago (2014-08-11 15:45:44 UTC) #7
dusmil.imgtec
6 years, 4 months ago (2014-08-11 15:46:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 manually as 23050 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698