Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: tools/skpdiff/SkDiffContext.h

Issue 457203003: Modify skpdiff to write diffs directly to provided directories (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Removed some dead code Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/skpdiff/SkDiffContext.h
diff --git a/tools/skpdiff/SkDiffContext.h b/tools/skpdiff/SkDiffContext.h
index 996737f2eed6e3ac1ce89411c8fde4b4e9e4aa02..793c5028ce51edd836559638f7f432471ba75bdb 100644
--- a/tools/skpdiff/SkDiffContext.h
+++ b/tools/skpdiff/SkDiffContext.h
@@ -52,6 +52,15 @@ public:
void setWhiteDiffDir(const SkString& directory);
/**
+ * Sets a flag wether to generate file names that a combination
epoger 2014/08/12 19:52:24 I find the description confusing... maybe somethin
stephana 2014/08/12 21:36:49 Ok. Will do. On 2014/08/12 19:52:24, epoger wrot
+ * of the baseline and test input files.
+ *
+ * If false the output file names are the common prefix of the
+ * two inputs.
+ */
+ void setLongNames(const bool useLongNames);
+
+ /**
* Sets the differs to be used in each diff. Already started diffs will not retroactively use
* these.
* @param differs An array of differs to use. The array is copied, but not the differs
@@ -177,6 +186,7 @@ private:
SkString fAlphaMaskDir;
SkString fRgbDiffDir;
SkString fWhiteDiffDir;
+ bool longNames;
};
#endif

Powered by Google App Engine
This is Rietveld 408576698